Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix React 19 compat #624

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Fix React 19 compat #624

merged 1 commit into from
Dec 6, 2024

Conversation

JoviDeCroock
Copy link
Member

Resolves #622

Currently we import ReactCurrentDispatcher in the auto flow which won't work, however we already have an explicit error in the runtime that React 19 won't work. In a future major we can axe the auto runtime completely.

Copy link

changeset-bot bot commented Dec 6, 2024

🦋 Changeset detected

Latest commit: f338044

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@preact/signals-react-transform Minor
@preact/signals-react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Dec 6, 2024

Deploy Preview for preact-signals-demo ready!

Name Link
🔨 Latest commit f338044
🔍 Latest deploy log https://app.netlify.com/sites/preact-signals-demo/deploys/675293f3f66b96000846f2af
😎 Deploy Preview https://deploy-preview-624--preact-signals-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Dec 6, 2024

Size Change: +43 B (+0.05%)

Total Size: 83.3 kB

Filename Size Change
docs/dist/assets/client.********.js 46.4 kB +42 B (+0.09%)
docs/dist/nesting-********.js 1.13 kB +1 B (+0.09%)
ℹ️ View Unchanged
Filename Size
docs/dist/assets/bench.********.js 1.59 kB
docs/dist/assets/index.********.js 835 B
docs/dist/assets/jsxRuntime.module.********.js 284 B
docs/dist/assets/preact.module.********.js 4.03 kB
docs/dist/assets/signals-core.module.********.js 1.41 kB
docs/dist/assets/signals.module.********.js 2.08 kB
docs/dist/assets/style.********.js 21 B
docs/dist/assets/style.********.css 1.24 kB
docs/dist/basic-********.js 243 B
docs/dist/demos-********.js 3.44 kB
docs/dist/react-********.js 242 B
packages/core/dist/signals-core.js 1.45 kB
packages/core/dist/signals-core.mjs 1.47 kB
packages/preact/dist/signals.js 1.35 kB
packages/preact/dist/signals.mjs 1.3 kB
packages/react-transform/dist/signals-*********.js 5.03 kB
packages/react-transform/dist/signals-transform.mjs 4.27 kB
packages/react-transform/dist/signals-transform.umd.js 5.15 kB
packages/react/dist/signals.js 188 B
packages/react/dist/signals.mjs 150 B

compressed-size-action

@JoviDeCroock JoviDeCroock mentioned this pull request Dec 6, 2024
@JoviDeCroock JoviDeCroock merged commit 18b2f29 into main Dec 6, 2024
6 checks passed
@JoviDeCroock JoviDeCroock deleted the react-19 branch December 6, 2024 09:10
This was referenced Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support React 19
2 participants