Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix effect behavior when first run throws #245

Merged
merged 2 commits into from
Oct 17, 2022
Merged

Fix effect behavior when first run throws #245

merged 2 commits into from
Oct 17, 2022

Conversation

jviide
Copy link
Contributor

@jviide jviide commented Oct 17, 2022

This pull request fixes a bug mentioned by @felixschorer in #241. If the first run of an effect throws the effect should be disposed.

@changeset-bot
Copy link

changeset-bot bot commented Oct 17, 2022

🦋 Changeset detected

Latest commit: 7e15d3c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@preact/signals-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Oct 17, 2022

Deploy Preview for preact-signals-demo ready!

Name Link
🔨 Latest commit 7e15d3c
🔍 Latest deploy log https://app.netlify.com/sites/preact-signals-demo/deploys/634d15b3557a45000876640e
😎 Deploy Preview https://deploy-preview-245--preact-signals-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 👍

@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2022

Size Change: +268 B (0%)

Total Size: 68.3 kB

Filename Size Change
docs/dist/assets/client.********.js 46.4 kB +1 B (0%)
docs/dist/assets/index.********.js 1.08 kB +242 B (+29%) 🚨
docs/dist/assets/signals-core.module.********.js 1.34 kB +11 B (+1%)
docs/dist/assets/signals.module.********.js 1.97 kB -1 B (0%)
docs/dist/basic-********.js 245 B -1 B (0%)
docs/dist/demos-********.js 3.35 kB -1 B (0%)
docs/dist/nesting-********.js 1.13 kB +1 B (0%)
docs/dist/react-********.js 238 B -1 B (0%)
packages/core/dist/signals-core.js 1.4 kB +10 B (+1%)
packages/core/dist/signals-core.mjs 1.43 kB +7 B (0%)
ℹ️ View Unchanged
Filename Size
docs/dist/assets/jsxRuntime.module.********.js 282 B
docs/dist/assets/preact.module.********.js 4 kB
docs/dist/assets/style.********.js 21 B
docs/dist/assets/style.********.css 1.21 kB
packages/preact/dist/signals.js 1.2 kB
packages/preact/dist/signals.mjs 1.15 kB
packages/react/dist/signals.js 1 kB
packages/react/dist/signals.mjs 919 B

compressed-size-action

@jviide jviide merged commit ccb677b into main Oct 17, 2022
@jviide jviide deleted the fix-effect-barf branch October 17, 2022 08:50
@github-actions github-actions bot mentioned this pull request Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants