Conversation
|
✅ Deploy Preview for preact-signals-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Contributor
|
Size Change: +106 B (0%) Total Size: 67.2 kB
ℹ️ View Unchanged
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reimplements
useSignal(),useComputed()anduseEffect()without usingpreact/hooks. This should offer some performance advantages, because the three hooks we provide can all be implemented using the same very simple "indexed slot" mechanism, effectively an inline implementation of theuseMemohook.There are some possible drawbacks here though: I don't know if this will mess up DevTools, and it's possible it would make Prefresh's job more difficult (though I also wonder if it gives Prefresh a useful way to differentiate between Signals and Hooks?).