Changing batch to use a single flag instead of a counter#143
Merged
marvinhagemeister merged 2 commits intopreactjs:mainfrom Sep 14, 2022
Merged
Changing batch to use a single flag instead of a counter#143marvinhagemeister merged 2 commits intopreactjs:mainfrom
marvinhagemeister merged 2 commits intopreactjs:mainfrom
Conversation
🦋 Changeset detectedLatest commit: f2ba3d6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for preact-signals-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
marvinhagemeister
approved these changes
Sep 14, 2022
Member
marvinhagemeister
left a comment
marvinhagemeister
left a comment
There was a problem hiding this comment.
Awesome, this is great! Thank you for the PR 👍
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #104, I'm going to try and split the improvements into multiple smaller PRs.
All of the tests pass, but this does slightly change the behavior, so I hope it doesn't break anybody's code.