Skip to content

Save bytes on hydration 2.0 #4894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JoviDeCroock merged 5 commits into from
Aug 22, 2025
Merged

Save bytes on hydration 2.0 #4894

JoviDeCroock merged 5 commits into from
Aug 22, 2025
+23 −21

Conversation

@JoviDeCroock
Copy link
Member

@JoviDeCroock JoviDeCroock commented Aug 20, 2025

More ideas are 100% welcomed

@github-actions
Copy link

github-actions bot commented Aug 20, 2025 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

duration

  • create10k: unsure 🔍 -1% - +0% (-7.16ms - +0.68ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -0% - +0% (-0.04ms - +0.02ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -1% - +3% (-0.82ms - +2.25ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -1% - +4% (-0.13ms - +0.65ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -2% - +3% (-1.18ms - +2.07ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -4% - +5% (-0.07ms - +0.09ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -1% - +1% (-0.21ms - +0.17ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -3% - +4% (-0.93ms - +1.18ms)
    preact-local vs preact-main

usedJSHeapSize

  • create10k: unsure 🔍 -0% - +0% (-0.01ms - +0.00ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -6% - +7% (-0.39ms - +0.45ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -0% - +0% (-0.01ms - +0.00ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -1% - +1% (-0.02ms - +0.02ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -3% - +4% (-0.03ms - +0.04ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -0% - -0% (-0.00ms - -0.00ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -0% - +1% (-0.01ms - +0.01ms)
    preact-local vs preact-main

Results

create10k

duration

VersionAvg timevs preact-localvs preact-main
preact-local972.09ms - 977.15ms-unsure 🔍
-1% - +0%
-7.16ms - +0.68ms
preact-main974.87ms - 980.85msunsure 🔍
-0% - +1%
-0.68ms - +7.16ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local19.03ms - 19.03ms-unsure 🔍
-0% - +0%
-0.01ms - +0.00ms
preact-main19.03ms - 19.05msunsure 🔍
-0% - +0%
-0.00ms - +0.01ms		-
filter-list

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.50ms - 16.54ms-unsure 🔍
-0% - +0%
-0.04ms - +0.02ms
preact-main16.51ms - 16.55msunsure 🔍
-0% - +0%
-0.02ms - +0.04ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.54ms - 1.54ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main1.54ms - 1.54msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
hydrate1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local70.69ms - 72.92ms-unsure 🔍
-1% - +3%
-0.82ms - +2.25ms
preact-main70.03ms - 72.14msunsure 🔍
-3% - +1%
-2.25ms - +0.82ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local6.10ms - 6.71ms-unsure 🔍
-6% - +7%
-0.39ms - +0.45ms
preact-main6.09ms - 6.66msunsure 🔍
-7% - +6%
-0.45ms - +0.39ms		-
many-updates

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.23ms - 16.77ms-unsure 🔍
-1% - +4%
-0.13ms - +0.65ms
preact-main15.96ms - 16.53msunsure 🔍
-4% - +1%
-0.65ms - +0.13ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.72ms - 3.72ms-unsure 🔍
-0% - +0%
-0.01ms - +0.00ms
preact-main3.72ms - 3.73msunsure 🔍
-0% - +0%
-0.00ms - +0.01ms		-
replace1k
  • Browser: chrome-headless
  • Sample size: 100
  • Built by: CI #5084

  • Commit: 86dedc6

duration

VersionAvg timevs preact-localvs preact-main
preact-local65.81ms - 68.05ms-unsure 🔍
-2% - +3%
-1.18ms - +2.07ms
preact-main65.31ms - 67.66msunsure 🔍
-3% - +2%
-2.07ms - +1.18ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.00ms - 3.02ms-unsure 🔍
-1% - +1%
-0.02ms - +0.02ms
preact-main3.00ms - 3.03msunsure 🔍
-1% - +1%
-0.02ms - +0.02ms		-

run-warmup-0

VersionAvg timevs preact-localvs preact-main
preact-local25.60ms - 26.43ms-unsure 🔍
-5% - +0%
-1.23ms - +0.05ms
preact-main26.11ms - 27.10msunsure 🔍
-0% - +5%
-0.05ms - +1.23ms		-

run-warmup-1

VersionAvg timevs preact-localvs preact-main
preact-local33.26ms - 34.39ms-unsure 🔍
-3% - +2%
-0.93ms - +0.56ms
preact-main33.52ms - 34.50msunsure 🔍
-2% - +3%
-0.56ms - +0.93ms		-

run-warmup-2

VersionAvg timevs preact-localvs preact-main
preact-local33.17ms - 34.17ms-unsure 🔍
-2% - +2%
-0.68ms - +0.67ms
preact-main33.23ms - 34.13msunsure 🔍
-2% - +2%
-0.67ms - +0.68ms		-

run-warmup-3

VersionAvg timevs preact-localvs preact-main
preact-local26.28ms - 27.06ms-unsure 🔍
-2% - +2%
-0.50ms - +0.59ms
preact-main26.25ms - 27.01msunsure 🔍
-2% - +2%
-0.59ms - +0.50ms		-

run-warmup-4

VersionAvg timevs preact-localvs preact-main
preact-local23.98ms - 25.17ms-unsure 🔍
-7% - +0%
-1.72ms - +0.02ms
preact-main24.79ms - 26.06msunsure 🔍
-0% - +7%
-0.02ms - +1.72ms		-

run-final

VersionAvg timevs preact-localvs preact-main
preact-local22.11ms - 23.09ms-unsure 🔍
-2% - +4%
-0.46ms - +0.89ms
preact-main21.92ms - 22.85msunsure 🔍
-4% - +2%
-0.89ms - +0.46ms		-
text-update

duration

VersionAvg timevs preact-localvs preact-main
preact-local1.80ms - 1.91ms-unsure 🔍
-4% - +5%
-0.07ms - +0.09ms
preact-main1.79ms - 1.91msunsure 🔍
-5% - +4%
-0.09ms - +0.07ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local0.98ms - 1.03ms-unsure 🔍
-3% - +4%
-0.03ms - +0.04ms
preact-main0.97ms - 1.02msunsure 🔍
-4% - +3%
-0.04ms - +0.03ms		-
todo

duration

VersionAvg timevs preact-localvs preact-main
preact-local31.12ms - 31.44ms-unsure 🔍
-1% - +1%
-0.21ms - +0.17ms
preact-main31.20ms - 31.40msunsure 🔍
-1% - +1%
-0.17ms - +0.21ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.25ms - 1.25ms-unsure 🔍
-0% - -0%
-0.00ms - -0.00ms
preact-main1.25ms - 1.25msunsure 🔍
+0% - +0%
+0.00ms - +0.00ms		-
update10th1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local30.97ms - 32.53ms-unsure 🔍
-3% - +4%
-0.93ms - +1.18ms
preact-main30.90ms - 32.34msunsure 🔍
-4% - +3%
-1.18ms - +0.93ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local2.93ms - 2.95ms-unsure 🔍
-0% - +1%
-0.01ms - +0.01ms
preact-main2.93ms - 2.94msunsure 🔍
-1% - +0%
-0.01ms - +0.01ms		-

tachometer-reporter-action v2 for CI

@github-actions
Copy link

github-actions bot commented Aug 20, 2025 •
edited
Loading

Size Change: -32 B (-0.07%)

Total Size: 47.5 kB

Filename Size Change
dist/preact.js 4.7 kB -11 B (-0.23%)
dist/preact.mjs 4.71 kB -11 B (-0.23%)
dist/preact.umd.js 4.77 kB -10 B (-0.21%)
ℹ️ View Unchanged
Filename Size
compat/dist/compat.js 3.9 kB
compat/dist/compat.mjs 3.82 kB
compat/dist/compat.umd.js 3.95 kB
debug/dist/debug.js 3.9 kB
debug/dist/debug.mjs 3.9 kB
debug/dist/debug.umd.js 3.98 kB
devtools/dist/devtools.js 263 B
devtools/dist/devtools.mjs 273 B
devtools/dist/devtools.umd.js 348 B
hooks/dist/hooks.js 1.55 kB
hooks/dist/hooks.mjs 1.58 kB
hooks/dist/hooks.umd.js 1.62 kB
jsx-runtime/dist/jsxRuntime.js 892 B
jsx-runtime/dist/jsxRuntime.mjs 861 B
jsx-runtime/dist/jsxRuntime.umd.js 966 B
test-utils/dist/testUtils.js 473 B
test-utils/dist/testUtils.mjs 473 B
test-utils/dist/testUtils.umd.js 555 B

compressed-size-action

@coveralls
Copy link

coveralls commented Aug 20, 2025 •
edited
Loading

Coverage Status

coverage: 99.536%. remained the same
when pulling 86dedc6 on save-bytes-hydration
into 18432f9 on main.

marvinhagemeister
marvinhagemeister approved these changes Aug 21, 2025
View reviewed changes
Copy link
Member

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JoviDeCroock JoviDeCroock merged commit 665126a into main Aug 22, 2025
13 checks passed
@JoviDeCroock JoviDeCroock deleted the save-bytes-hydration branch August 22, 2025 05:54
rschristian
rschristian reviewed Aug 22, 2025
View reviewed changes
src/diff/index.js
// If the previous diff bailed out, resume creating/hydrating.
if (oldVNode._flags & MODE_SUSPENDED) {
isHydrating = !!(oldVNode._flags & MODE_HYDRATE);
if (oldVNode._component._excess) {
Copy link
Member

@rschristian rschristian Aug 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have yet to dig into an attempt to reproduce but the removal of this check is causing CI failures in iso. Was it intentionally removed? I'd think we'd still need it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rschristian rschristian rschristian left review comments

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@JoviDeCroock @coveralls @marvinhagemeister @rschristian