Skip to content

feat: Add onBeforeToggle event handler type #4694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rschristian merged 1 commit into from
Feb 19, 2025
Merged

feat: Add onBeforeToggle event handler type #4694

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/jsx.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -625,7 +625,8 @@ export namespace JSXInternal {
onCompositionUpdate?: CompositionEventHandler<Target> | undefined;
onCompositionUpdateCapture?: CompositionEventHandler<Target> | undefined;

// Details Events
// Popover Events
onBeforeToggle?: ToggleEventHandler<Target> | undefined;
onToggle?: ToggleEventHandler<Target> | undefined;
Copy link
Contributor Author

@lukewarlow lukewarlow Feb 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DetailsHTMLAttributes has an onToggle defined too, but as a GenericEventHandler idk if that should be removed or if it is in addition to this type (can't really remember how TS works).

Copy link
Member

@rschristian rschristian Feb 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That'd be a mistake -- IIRC, the DetailsHTMLAttributes interface was created prior, then moved into this module. Later we added this entry with a backport of the correct event handler type. I think the DetailsHTML interface will take precedence too so that should probably be removed in favor of this "global" type, but that can be done separately later.

I think in the future we'll try to break up this mega list of events too, try to restrict them (where appropriate) to specific elements.


// Dialog Events
Expand Down
Loading