Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Warn on NaN in dep arrays instead of throwing #4527

Merged
merged 2 commits into from
Oct 12, 2024

Conversation

rschristian
Copy link
Member

@rschristian rschristian commented Oct 12, 2024

Closes: #4344

It'll fix the issue of debug throwing & killing the app, but whether or not this works correctly is still very usage-dependent.

Will depend on #4528, as our benchmarks require a successful asset upload from main to be able to run, and its CI currently fails.

Copy link

github-actions bot commented Oct 12, 2024

Size Change: +6 B (+0.01%)

Total Size: 62.1 kB

Filename Size Change
debug/dist/debug.js 3.82 kB +2 B (+0.05%)
debug/dist/debug.module.js 3.83 kB +2 B (+0.05%)
debug/dist/debug.umd.js 3.9 kB +2 B (+0.05%)
ℹ️ View Unchanged
Filename Size
compat/dist/compat.js 4.13 kB
compat/dist/compat.module.js 4.05 kB
compat/dist/compat.umd.js 4.19 kB
devtools/dist/devtools.js 260 B
devtools/dist/devtools.module.js 274 B
devtools/dist/devtools.umd.js 346 B
dist/preact.js 4.67 kB
dist/preact.min.js 4.69 kB
dist/preact.min.module.js 4.69 kB
dist/preact.min.umd.js 4.72 kB
dist/preact.module.js 4.68 kB
dist/preact.umd.js 4.73 kB
hooks/dist/hooks.js 1.53 kB
hooks/dist/hooks.module.js 1.56 kB
hooks/dist/hooks.umd.js 1.6 kB
jsx-runtime/dist/jsxRuntime.js 976 B
jsx-runtime/dist/jsxRuntime.module.js 949 B
jsx-runtime/dist/jsxRuntime.umd.js 1.05 kB
test-utils/dist/testUtils.js 451 B
test-utils/dist/testUtils.module.js 456 B
test-utils/dist/testUtils.umd.js 536 B

compressed-size-action

@rschristian rschristian force-pushed the refactor/nan-warn branch 2 times, most recently from 85a3024 to 65563e4 Compare October 12, 2024 05:55
@coveralls
Copy link

coveralls commented Oct 12, 2024

Coverage Status

coverage: 99.488%. remained the same
when pulling 88e74bd on refactor/nan-warn
into d54bd31 on main.

workflow: build-test.yml
workflow: ci.yml
Copy link
Member Author

@rschristian rschristian Oct 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI should now be completely on track again.

Sorry the recent changes had so many issues, the fact that our setup runs both the PR & main workflows (as they exist on both branches) simultaneously made this a bit weird to figure out all the details on.

@rschristian rschristian marked this pull request as ready for review October 12, 2024 06:10
@rschristian rschristian merged commit 675bcad into main Oct 12, 2024
13 checks passed
@rschristian rschristian deleted the refactor/nan-warn branch October 12, 2024 06:28
@JoviDeCroock JoviDeCroock mentioned this pull request Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants