ci: Unify workflows into singular pipeline #4520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rschristian
force-pushed
the
ci/refactor
branch
from
a487a95
to
076f88a
Compare
|
Size Change: 0 B Total Size: 62 kB ℹ️ View Unchanged
|
rschristian
changed the title
|
The required status checks in the repo will need to be altered if this is to land; |
JoviDeCroock
approved these changes
Oct 3, 2024
Thompson1985
approved these changes
Oct 6, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we run 3 separate pipelines for each PR (assuming the PR touches source JS, we do have a bit of filtering in play):
As such, we're running the CI workflow twice (once directly, once called from Benchmarks) which, while not necessarily problematic as it's done in parallel, can be a bit noisy in the case of build/test failures (each will notify of failure separately) and is duplicated work at the very least. 3 separate pipelines is also a bit messy if you need to jump into the 'Actions' tab to check/compare different runs -- far from a major problem, but less than ideal IMO.
The idea here is to unify the aforementioned workflows into a singular pipeline; we'll get an overview of all jobs at once, make the control flow a bit more obvious & easier to edit, and skip some duplicated work.
ci.ymlwill therefore be the orchestrator, triggering the runs ofbuild-test.yml,benchmarks.yml, &size.yml, they'll no longer be entrypoints/pipelines themselves.Workflow run in pic