Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use event.currentTarget as the this for events #3146

Closed
wants to merge 3 commits into from

Conversation

JoviDeCroock
Copy link
Member

Fixes: #3137

@github-actions
Copy link

github-actions bot commented May 11, 2021

📊 Tachometer Benchmark Results

Summary

duration

  • 02_replace1k: unsure 🔍 -1% - +4% (-1.78ms - +6.64ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -7% - +0% (-2.28ms - +0.05ms)
    preact-local vs preact-master
  • 07_create10k: unsure 🔍 -2% - +0% (-24.92ms - +5.10ms)
    preact-local vs preact-master
  • filter_list: unsure 🔍 -2% - +2% (-0.52ms - +0.62ms)
    preact-local vs preact-master
  • hydrate1k: unsure 🔍 -2% - +3% (-2.95ms - +3.88ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -4% - +3% (-1.35ms - +1.02ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 -4% - +4% (-0.13ms - +0.12ms)
    preact-local vs preact-master

usedJSHeapSize

  • 02_replace1k: slower ❌ 0% - 1% (0.01ms - 0.05ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -1% - +0% (-0.02ms - +0.00ms)
    preact-local vs preact-master
  • 07_create10k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • filter_list: slower ❌ 1% - 4% (0.01ms - 0.07ms)
    preact-local vs preact-master
  • hydrate1k: unsure 🔍 -0% - +1% (-0.02ms - +0.07ms)
    preact-local vs preact-master
  • many_updates: slower ❌ 0% - 1% (0.00ms - 0.03ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
    preact-local vs preact-master

Results

02_replace1k

duration

VersionAvg timevs preact-mastervs preact-local
preact-master171.53ms - 177.83ms-unsure 🔍
-4% - +1%
-6.64ms - +1.78ms
preact-local174.31ms - 179.91msunsure 🔍
-1% - +4%
-1.78ms - +6.64ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master3.56ms - 3.59ms-faster ✔
0% - 1%
0.01ms - 0.05ms
preact-local3.59ms - 3.62msslower ❌
0% - 1%
0.01ms - 0.05ms
-

run-warmup-0

VersionAvg timevs preact-mastervs preact-local
preact-master67.21ms - 68.99ms-unsure 🔍
-4% - +0%
-2.53ms - +0.31ms
preact-local68.10ms - 70.32msunsure 🔍
-0% - +4%
-0.31ms - +2.53ms
-

run-warmup-1

VersionAvg timevs preact-mastervs preact-local
preact-master111.02ms - 113.79ms-unsure 🔍
-2% - +1%
-2.45ms - +1.45ms
preact-local111.53ms - 114.28msunsure 🔍
-1% - +2%
-1.45ms - +2.45ms
-

run-warmup-2

VersionAvg timevs preact-mastervs preact-local
preact-master103.30ms - 113.85ms-unsure 🔍
-5% - +8%
-5.82ms - +8.69ms
preact-local102.15ms - 112.12msunsure 🔍
-8% - +5%
-8.69ms - +5.82ms
-

run-warmup-3

VersionAvg timevs preact-mastervs preact-local
preact-master76.40ms - 83.97ms-unsure 🔍
-7% - +6%
-5.74ms - +5.06ms
preact-local76.68ms - 84.37msunsure 🔍
-6% - +7%
-5.06ms - +5.74ms
-

run-warmup-4

VersionAvg timevs preact-mastervs preact-local
preact-master109.17ms - 114.12ms-unsure 🔍
-5% - +1%
-5.69ms - +1.68ms
preact-local110.92ms - 116.38msunsure 🔍
-2% - +5%
-1.68ms - +5.69ms
-

run-final

VersionAvg timevs preact-mastervs preact-local
preact-master73.73ms - 77.26ms-unsure 🔍
-5% - +2%
-3.48ms - +1.23ms
preact-local75.05ms - 78.18msunsure 🔍
-2% - +5%
-1.23ms - +3.48ms
-
03_update10th1k_x16

duration

VersionAvg timevs preact-mastervs preact-local
preact-master32.78ms - 34.50ms-unsure 🔍
-0% - +7%
-0.05ms - +2.28ms
preact-local31.74ms - 33.32msunsure 🔍
-7% - +0%
-2.28ms - +0.05ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master3.59ms - 3.60ms-unsure 🔍
-0% - +1%
-0.00ms - +0.02ms
preact-local3.58ms - 3.60msunsure 🔍
-1% - +0%
-0.02ms - +0.00ms
-
07_create10k

duration

VersionAvg timevs preact-mastervs preact-local
preact-master1401.74ms - 1423.13ms-unsure 🔍
-0% - +2%
-5.10ms - +24.92ms
preact-local1391.99ms - 1413.05msunsure 🔍
-2% - +0%
-24.92ms - +5.10ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master25.38ms - 25.38ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local25.38ms - 25.38msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
filter_list

duration

VersionAvg timevs preact-mastervs preact-local
preact-master24.91ms - 25.68ms-unsure 🔍
-2% - +2%
-0.62ms - +0.52ms
preact-local24.92ms - 25.77msunsure 🔍
-2% - +2%
-0.52ms - +0.62ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master1.62ms - 1.66ms-faster ✔
1% - 4%
0.01ms - 0.07ms
preact-local1.66ms - 1.70msslower ❌
1% - 4%
0.01ms - 0.07ms
-
hydrate1k

duration

VersionAvg timevs preact-mastervs preact-local
preact-master133.13ms - 137.54ms-unsure 🔍
-3% - +2%
-3.88ms - +2.95ms
preact-local133.19ms - 138.41msunsure 🔍
-2% - +3%
-2.95ms - +3.88ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master6.27ms - 6.33ms-unsure 🔍
-1% - +0%
-0.07ms - +0.02ms
preact-local6.29ms - 6.36msunsure 🔍
-0% - +1%
-0.02ms - +0.07ms
-
many_updates

duration

VersionAvg timevs preact-mastervs preact-local
preact-master32.04ms - 33.71ms-unsure 🔍
-3% - +4%
-1.02ms - +1.35ms
preact-local31.86ms - 33.56msunsure 🔍
-4% - +3%
-1.35ms - +1.02ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master4.65ms - 4.66ms-faster ✔
0% - 1%
0.00ms - 0.03ms
preact-local4.66ms - 4.68msslower ❌
0% - 1%
0.00ms - 0.03ms
-
text_update

duration

VersionAvg timevs preact-mastervs preact-local
preact-master2.79ms - 2.97ms-unsure 🔍
-4% - +4%
-0.12ms - +0.13ms
preact-local2.79ms - 2.96msunsure 🔍
-4% - +4%
-0.13ms - +0.12ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master0.83ms - 0.83ms-unsure 🔍
-0% - -0%
-0.00ms - -0.00ms
preact-local0.83ms - 0.83msunsure 🔍
+0% - +0%
+0.00ms - +0.00ms
-

tachometer-reporter-action v2 for Benchmarks

@github-actions
Copy link

github-actions bot commented May 11, 2021

Size Change: +31 B (0%)

Total Size: 42 kB

Filename Size Change
dist/preact.js 3.99 kB +7 B (0%)
dist/preact.min.js 4.01 kB +7 B (0%)
dist/preact.module.js 4.01 kB +8 B (0%)
dist/preact.umd.js 4.05 kB +9 B (0%)
ℹ️ View Unchanged
Filename Size Change
compat/dist/compat.js 3.39 kB 0 B
compat/dist/compat.module.js 3.38 kB 0 B
compat/dist/compat.umd.js 3.44 kB 0 B
debug/dist/debug.js 2.99 kB 0 B
debug/dist/debug.module.js 2.98 kB 0 B
debug/dist/debug.umd.js 3.07 kB 0 B
devtools/dist/devtools.js 232 B 0 B
devtools/dist/devtools.module.js 241 B 0 B
devtools/dist/devtools.umd.js 308 B 0 B
hooks/dist/hooks.js 1.13 kB 0 B
hooks/dist/hooks.module.js 1.15 kB 0 B
hooks/dist/hooks.umd.js 1.2 kB 0 B
jsx-runtime/dist/jsxRuntime.js 317 B 0 B
jsx-runtime/dist/jsxRuntime.module.js 327 B 0 B
jsx-runtime/dist/jsxRuntime.umd.js 395 B 0 B
test-utils/dist/testUtils.js 437 B 0 B
test-utils/dist/testUtils.module.js 439 B 0 B
test-utils/dist/testUtils.umd.js 515 B 0 B

compressed-size-action

@coveralls
Copy link

coveralls commented May 11, 2021

Coverage Status

Coverage remained the same at 99.622% when pulling 97845f4 on use-current-target-as-this into 8268cc8 on master.

@developit
Copy link
Member

developit commented May 11, 2021

Can't we just change the types? Using event.currentTarget can cause issues with Shadow DOM and bubbling.
(edit: see #3137 (comment))

@JoviDeCroock JoviDeCroock deleted the use-current-target-as-this branch May 12, 2021 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The type of this is not event.currentTarget onChange events
3 participants