Skip to content

Conversation

@marvinhagemeister
Copy link
Member

@marvinhagemeister marvinhagemeister commented Aug 10, 2020

This PR adds support for react-relay in our compatibility layer. It was tested with the official example todo demo app.

__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED

So far it is the first library that makes use of the famous __SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED variable by React. The only other usage I've seen so far is in the react-devtools codebase.

fire

Fixes #411 .

Note that the original issue was for an older version of react-relay. I'm not able to reproduce the mentioned issue with the latest version anymore.

@github-actions
Copy link

github-actions bot commented Aug 10, 2020

Size Change: +370 B (0%)

Total Size: 40.9 kB

Filename Size Change
compat/dist/compat.js 3.38 kB +126 B (3%)
compat/dist/compat.module.js 3.4 kB +116 B (3%)
compat/dist/compat.umd.js 3.44 kB +128 B (3%)
ℹ️ View Unchanged
Filename Size Change
debug/dist/debug.js 3.06 kB 0 B
debug/dist/debug.module.js 3.06 kB 0 B
debug/dist/debug.umd.js 3.15 kB 0 B
devtools/dist/devtools.js 185 B 0 B
devtools/dist/devtools.module.js 195 B 0 B
devtools/dist/devtools.umd.js 260 B 0 B
dist/preact.js 3.97 kB 0 B
dist/preact.min.js 4 kB 0 B
dist/preact.module.js 3.99 kB 0 B
dist/preact.umd.js 4.03 kB 0 B
hooks/dist/hooks.js 1.09 kB 0 B
hooks/dist/hooks.module.js 1.11 kB 0 B
hooks/dist/hooks.umd.js 1.17 kB 0 B
test-utils/dist/testUtils.js 437 B 0 B
test-utils/dist/testUtils.module.js 439 B 0 B
test-utils/dist/testUtils.umd.js 515 B 0 B

compressed-size-action

@coveralls
Copy link

coveralls commented Aug 10, 2020

Coverage Status

Coverage increased (+0.002%) to 99.804% when pulling 1052866 on relay-support into 7eb87b7 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Preact and Relay

5 participants