Skip to content

(fix) - Set value/checked on custom-elements #2465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 12, 2020

Conversation

JoviDeCroock
Copy link
Member

When we are dealing with custom-elements setting it on the node itself isn't sufficient we have to ensure it is propagated through.

I'll ask the OP if this resolves the issue, since I'm not entirely sure

Fixes: #2464

@github-actions
Copy link

github-actions bot commented Apr 11, 2020

Size Change: -37 B (0%)

Total Size: 39 kB

Filename Size Change
dist/preact.js 3.8 kB -9 B (0%)
dist/preact.min.js 3.8 kB -9 B (0%)
dist/preact.module.js 3.81 kB -9 B (0%)
dist/preact.umd.js 3.86 kB -10 B (0%)
ℹ️ View Unchanged
Filename Size Change
compat/dist/compat.js 3.12 kB 0 B
compat/dist/compat.module.js 3.14 kB 0 B
compat/dist/compat.umd.js 3.17 kB 0 B
debug/dist/debug.js 3 kB 0 B
debug/dist/debug.module.js 2.98 kB 0 B
debug/dist/debug.umd.js 3.08 kB 0 B
devtools/dist/devtools.js 175 B 0 B
devtools/dist/devtools.module.js 185 B 0 B
devtools/dist/devtools.umd.js 252 B 0 B
hooks/dist/hooks.js 1.05 kB 0 B
hooks/dist/hooks.module.js 1.08 kB 0 B
hooks/dist/hooks.umd.js 1.12 kB 0 B
test-utils/dist/testUtils.js 437 B 0 B
test-utils/dist/testUtils.module.js 439 B 0 B
test-utils/dist/testUtils.umd.js 515 B 0 B

compressed-size-action

@github-actions
Copy link

Coverage Status

Coverage remained the same at 99.8% when pulling 00f85d3 on support-value-checked-custom-elements into b69fc97 on master.

Copy link
Member

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet 🎉

@marvinhagemeister marvinhagemeister merged commit 3426ec5 into master Apr 12, 2020
@marvinhagemeister marvinhagemeister deleted the support-value-checked-custom-elements branch April 12, 2020 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'checked' is filtered and not assigned to DOM
2 participants