tooling: "exports" adjustments #2327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
developit
approved these changes
Feb 10, 2020
JoviDeCroock
approved these changes
Feb 10, 2020
marvinhagemeister
approved these changes
Feb 11, 2020
Member
marvinhagemeister
left a comment
marvinhagemeister
left a comment
There was a problem hiding this comment.
Awesome, thank you so much for your contribution 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
"exports"definitions to match the expectations of logical conditional exports ordering (nodejs/node#31008).The idea there is that we can think of the "exports" object as an ordered conditional like a series of if statements, which was integrated with feedback from tooling authors.
The definitions written here though would never match the "browser" or "umd" conditions because the "require" or "import" condition would act as a catch-all, like having an
if (true)with further if statements below.The general rule is to put the most specific conditional exports first, although I can appreciate if this might seem counter-intuitive.
Further discussion / feedback welcome.