-
-
Notifications
You must be signed in to change notification settings - Fork 522
add size-plugin*.json & update size-plugin config #338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
size-plugin-browser.json: size-plugin-ssr.json: |
seems like it missed one file( |
@developit @marvinhagemeister any idea why are we getting different hash for some of the assets. local machine: CI: |
|
@kuldeepkeshwar yes - I believe the hashes are based on full disk paths, which causes them to vary by machine. We should change that in preact-cli. |
|
Also I think we're doing an |
|
🤞 |
|
size-plugin-ssr |
|
1 more 😊 |
|
size-plugin-browser |
|
it worked 🎉🍕🍻🕺 |
marvinhagemeister
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good so far with a few minor nits👍
|
size-plugin-ssr |
|
size-plugin-browser |
|
size-plugin-ssr |
|
size-plugin-browser |
|
size-plugin-ssr |
|
size-plugin-browser |
|
Looking at the latest output it seems like the hashing isn't stable in |
Yup @developit pointed it out too, any reason we do path based hashing not the content-based? |
|
size-plugin-ssr |
|
size-plugin-browser |
|
size-plugin-ssr |
|
size-plugin-browser |
|
size-plugin-ssr |
|
size-plugin-browser |
|
size-plugin-ssr |
|
size-plugin-browser |
|
size-plugin-ssr |
|
size-plugin-browser |
|
size-plugin-ssr |
|
size-plugin-browser |
|
size-plugin-ssr |
|
size-plugin-browser |
|
size-plugin-ssr |
|
size-plugin-browser |
|
size-plugin-ssr |
|
size-plugin-browser |
|
@developit @marvinhagemeister we can merge this pr changes:
|
marvinhagemeister
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's happening 🎉💯
No description provided.