Skip to content

Add support for Fragments #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 20, 2019
Merged

Add support for Fragments #79

merged 2 commits into from
Mar 20, 2019

Conversation

@marvinhagemeister
Copy link
Member

@marvinhagemeister marvinhagemeister commented Mar 19, 2019

Fixes #78 🎉

andrewiggins
andrewiggins approved these changes Mar 20, 2019
View reviewed changes
Copy link
Member

@andrewiggins andrewiggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, it's so simple :)

I'd add one test that shows Fragments with multiple siblings rendering properly (a problem for us over in preact main)

@marvinhagemeister
Copy link
Member Author

marvinhagemeister commented Mar 20, 2019

Good idea! Added a test for sibling Fragments for the pretty renderer suite 👍 Yeah I know what you mean. We spent so much time on getting the client side implementation right. The SSR part is ridiculously easy in comparison 😂

@marvinhagemeister marvinhagemeister merged commit 7d3ccd4 into master Mar 20, 2019
@marvinhagemeister marvinhagemeister deleted the fragments branch March 20, 2019 21:06
@snyk-bot snyk-bot mentioned this pull request Oct 26, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewiggins andrewiggins andrewiggins approved these changes

@developit developit Awaiting requested review from developit

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@marvinhagemeister @andrewiggins