Resolve crash when using hooks #77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested this and with this fix no more crash, thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the external option for the build script from
nonetopreactwhich resolves the crash when using hooks. (preactjs/preact#1373)The test for hooks ran fine when using the
src, but crashed when usingdist(the __h of undefined error). The reason for this was that with external option set tononeresulted in the imported options from preact being an empty object (sooptions.renderwould not be called and hooks would crash).https://github.com/developit/preact-render-to-string/blob/8536c758e3d1808bcc18d64cd944da609531d11e/src/index.js#L66
Result difference in build:
Before:
1510 B (mjs)1567 B (js)After:
1487 B (mjs)1549 B (js)Difference:
-23 B (mjs)-18 B (js)