Remove text VNode casting #269
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 00986eb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This can be merged now that preactjs/preact#3801 has been merged. Need to update the preact version for tests to pass though. |
JoviDeCroock
approved these changes
Dec 3, 2022
marvinhagemeister
approved these changes
Dec 5, 2022
JoviDeCroock
force-pushed
the
remove-string-vnode-cast
branch
from
63189d0 to
e0b739f
Compare
JoviDeCroock
force-pushed
the
remove-string-vnode-cast
branch
from
ca5db6c to
009d029
Compare
|
Looks like this landed as part of #286 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the text VNode casting from #257, as we're now handling this difference internally in
preact/debug(preactjs/preact#3801). I'm only seeing a 1% performance improvement as a result of this change, but that should be a result of having already removed one of the per-text-vnode function calls in #241.