fix: Serialize defaultChecked & defaultSelected #224
Conversation
🦋 Changeset detectedLatest commit: d4e2386 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| } else if (isSvgMode && name.match(/^xlink:?./)) { | ||
| } else if (isSvgMode && /^xlink:?./.test(name)) { |
There was a problem hiding this comment.
Unrelated (sorry!) but .test() should be marginally faster.
|
There is also a https://html.spec.whatwg.org/multipage/form-elements.html#dom-option-defaultselected |
|
@rschristian do you want this merged already? Wanted to do a small release for the perf improvements |
|
@JoviDeCroock Sorry, must've missed or forgotten about this. Added in
Double Edit: Nope, my benchmark had issues. I was right the first time. |
rschristian
changed the title
Closes #223
Not sure if there are any other
defaultXprops to be concerned with (my memory and MDN are failing me). I think every other check / replace method would be a fair bit slower, so I imagine while limited to these two (defaultValueanddefaultChecked) this approach is better? LMK!