Skip to content

Fix accidental camelCasing of CSS Variables #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JoviDeCroock merged 3 commits into from
May 29, 2020
Merged

Fix accidental camelCasing of CSS Variables #153

JoviDeCroock merged 3 commits into from
May 29, 2020

Conversation

@developit
Copy link
Member

@developit developit commented May 29, 2020 

// before
styleObjToCss({ '--numStars': 5 })  // "--num-stars: 5;"

// after
styleObjToCss({ '--numStars': 5 })  // "--numStars: 5;"

@developit developit requested a review from JoviDeCroock May 29, 2020 19:38
@JoviDeCroock JoviDeCroock merged commit 864fc91 into master May 29, 2020
@JoviDeCroock JoviDeCroock deleted the fix-css-vars branch May 29, 2020 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoviDeCroock JoviDeCroock JoviDeCroock approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@developit @JoviDeCroock