Skip to content

Conversation

@rschristian
Copy link
Member

@rschristian rschristian commented Nov 30, 2024

Caught by the ecosystem-ci.

Comment on lines -87 to 86
it("should filter out __self", () => {
// @ts-expect-error
const vnode = h("div", { __self: "foo", foo: 1 });
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected by preactjs/preact#4578

@@ -1,6 +1,5 @@
import * as preact from './index';

-declare global {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now unnecessary thanks to preactjs/preact#4583

@rschristian rschristian marked this pull request as ready for review December 2, 2024 07:48
@JoviDeCroock JoviDeCroock merged commit 9a669ff into main Dec 4, 2024
1 check passed
@JoviDeCroock JoviDeCroock deleted the chore/bump-preact-10.25.1 branch December 4, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants