Skip to content

GitHub actions #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Dec 18, 2019
Merged

GitHub actions #20

merged 13 commits into from
Dec 18, 2019

Conversation

ForsakenHarmony
Copy link
Member

No description provided.

@developit
Copy link
Member

developit commented Dec 17, 2019 •
edited
Loading

Suggestion: we can switch this to karmatic and use the Preact SauceLabs key. I've just added SAUCE_USERNAME and SAUCE_ACCESS_KEY as secrets.

@ForsakenHarmony
Copy link
Member Author

Oh I thought you merged into master directly

marvinhagemeister
marvinhagemeister approved these changes Dec 18, 2019
View reviewed changes
Copy link
Member

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@marvinhagemeister marvinhagemeister merged commit 4348b61 into master Dec 18, 2019
@marvinhagemeister marvinhagemeister deleted the github-actions branch December 18, 2019 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ForsakenHarmony @developit @marvinhagemeister