Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support all maintained node versions in jest-preset-preact #898

Merged
merged 1 commit into from
Oct 1, 2019

Conversation

andreek
Copy link
Contributor

@andreek andreek commented Oct 1, 2019

What kind of change does this PR introduce?
bugfix

Did you add tests for your changes?
no

Summary
Update babel-jest in jest-preset-preact to support all maintained node versions. I run into the problem because I use node 12. I needed to change the value to "maintained node versions".

BrowserslistError: [BABEL] /test-preact/tests/header.test.js: Unknown browser node (While processing: "/test-preact/node_modules/babel-preset-env/lib/index.js")
at checkName (node_modules/babel-preset-env/node_modules/browserslist/index.js:112:20)
at Function.select (node_modules/babel-preset-env/node_modules/browserslist/index.js:675:18)
at node_modules/babel-preset-env/node_modules/browserslist/index.js:140:33
at Array.reduce (<anonymous>)
at resolve (node_modules/babel-preset-env/node_modules/browserslist/index.js:121:18)
at browserslist (node_modules/babel-preset-env/node_modules/browserslist/index.js:217:16)
at getTargets (node_modules/babel-preset-env/lib/targets-parser.js:103:63)
at buildPreset (node_modules/babel-preset-env/lib/index.js:144:45)
at node_modules/@babel/core/lib/config/full.js:167:14
at cachedFunction (node_modules/@babel/core/lib/config/caching.js:33:19)

#892 (comment)

Does this PR introduce a breaking change?
no

Other information
Environment Info:

  System:
    OS: Linux 5.3 Arch Linux undefined
    CPU: (8) x64 Intel(R) Core(TM) i7-8550U CPU @ 1.80GHz
  Binaries:
    Node: 12.10.0 - ~/.nvm/versions/node/v12.10.0/bin/node
    Yarn: 1.17.3 - ~/.nvm/versions/node/v12.10.0/bin/yarn
    npm: 6.10.3 - ~/.nvm/versions/node/v12.10.0/bin/npm
  Browsers:
    Firefox: 69.0.1
  npmGlobalPackages:
    preact-cli: 3.0.0-rc.5

Copy link
Member

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thank you so much for making a PR👍💯

@marvinhagemeister marvinhagemeister merged commit 2455618 into preactjs:master Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants