Skip to content

Conversation

@rschristian
Copy link
Member

What kind of change does this PR introduce?

Bug fix

Did you add tests for your changes?

No

Summary

Mistake from #1534

sw.js is not output if sw-esm.js is.

Functionally I'm not sure it makes any difference, but it was a mistake

Does this PR introduce a breaking change?

No

@rschristian rschristian requested a review from a team as a code owner November 19, 2021 04:36
@changeset-bot
Copy link

changeset-bot bot commented Nov 19, 2021

🦋 Changeset detected

Latest commit: 40c3b0b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
preact-cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@rschristian rschristian merged commit 9039ba2 into master Nov 21, 2021
@rschristian rschristian deleted the fix/non-esm-sw-generation branch November 21, 2021 13:36
@preact-bot preact-bot mentioned this pull request Nov 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants