Some paths in webpack configs aren't matched on Windows

Do you want to request a feature or report a bug?
Bug

What is the current behavior?
I discovered this bug because routes are named *.chunk.*.js instead of route-*.js in the build output. This happens because Windows' backslash-delimited file paths (e.g. C:\Users\me\dev\project\src\routes\home\index.js aren't matched by these strings and regexes:

https://github.com/developit/preact-cli/blob/9eb46228922b05ecf88c0803a64f8fa5f04b2ab7/src/lib/webpack/webpack-client-config.js#L55-L58

There are probably more occurences of this throughout the webpack configs.

If the current behavior is a bug, please provide the steps to reproduce.

preact create default test on Windows
cd test, npm install
npm run build
In the build folder, route chunks aren't prefixed with route-

What is the expected behavior?
In this specific case, routes should be prefixed with route-, like on UNIX systems.
Generally, both / and \-delimited paths should be matched in webpack configs.

Please mention other relevant information.

node version 8.9.1
npm version 5.6.0
Operating system Windows 10 1709

Thanks for this! Can you try the following for me:

const path = require('path');
//...
let normal = path.posix.normalize(filename);
let relative = normal.replace(src, '');
return normal.includes('/routes/') && 'route-' + relative.replace(/(^\/(routes|components\/(routes|async))\/|(\/index)?\.js$)/g, '');

That doesn't fix it, unfortunately. Relevant PR: nodejs/node#12700.

Ah, thanks! TIL :D Good reason I always avoided posix before.

How about this, the more cumbersome route:

const RGX = /[\\|\/]/g;
const toNorm = str => path.normalize(str).replace(RGX, '/');
// ...
filename = toNorm(filename);
if (!!~filename.indexOf('/routes/') return false;
let relative = filename.replace(toNorm(src), '');
return 'route-' + relative.replace(/(^\/(routes|components\/(routes|async))\/|(\/index)?\.js$)/g, '');

Sorry, no access to windows.

It works if I replace !!~filename with !filename (and add the missing bracket).

I can work on this myself and submit a PR when I have enough time, if you'd prefer that.

Also, TIL about ~ 😃

Great! You're welcome to open a pull request for that, or else I'll do it later.

Sorry about that lol, on my phone

Navigation Menu

Repository navigation

Some paths in webpack configs aren't matched on Windows #453

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Some paths in webpack configs aren't matched on Windows #453

Description

Activity

lukeed commented on Jan 5, 2018

jgierer12 commented on Jan 6, 2018

lukeed commented on Jan 6, 2018

jgierer12 commented on Jan 6, 2018

lukeed commented on Jan 6, 2018

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions