Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken jest tests #31

Merged
merged 1 commit into from
Oct 20, 2019
Merged

Fix broken jest tests #31

merged 1 commit into from
Oct 20, 2019

Conversation

scythianfuego
Copy link
Contributor

This fixes tests as noted by @andreek but has two ongoing issues:

  1. it references preact-cli 3.0.0-rc.5 as we have no better at the moment
  2. style.css fix should be done in preact-cli jest configuration instead -
    we need to add 'css' to moduleFileExtensions
    https://jestjs.io/docs/en/configuration#modulefileextensions-array-string

@scythianfuego scythianfuego mentioned this pull request Oct 1, 2019
Closed
marvinhagemeister
marvinhagemeister approved these changes Oct 20, 2019
View reviewed changes
Copy link
Contributor

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks a bunch for the PR 💯 👍

@marvinhagemeister marvinhagemeister changed the title Temporary fix for broken jest tests Fix broken jest tests Oct 20, 2019
@marvinhagemeister marvinhagemeister merged commit eed935b into preactjs-templates:master Oct 20, 2019
@reznord reznord mentioned this pull request Jul 10, 2020
Closed
@ForsakenHarmony ForsakenHarmony mentioned this pull request Sep 7, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scythianfuego @marvinhagemeister