Fix IndexError when shebang is just '#!/usr/bin/env' #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
is there an actual case where this came up? feels a bit like garbage-in-garbage-out |
|
I did come across it randomly due to a typo in a file. I agree that it is a pretty unlikely scenario, though it seems to be the only case where the library raises an exception due to the contents of the file. I suppose it's not too hard for client code to just check for this edge case if it may be a problem |
asottile
reviewed
Jul 1, 2024
harrymander
force-pushed
the
fix-index-error-with-env-shebang
branch
from
39c5d59
to
90c7a1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.