Skip to content

Nav drawer UI #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 88 commits into from
May 11, 2020
Merged

Nav drawer UI #94

merged 88 commits into from
May 11, 2020

Conversation

pravinyo
Copy link
Owner

@pravinyo pravinyo commented May 9, 2020

Fixed :

  • Progress bar issue
  • Download cancel issue

Screen:

  • Settings screen added
  • Navigation UI added to main screen

pravinyo added 30 commits May 6, 2020 23:38
@pravinyo
injected via di
1bbcfa3
@pravinyo
onCreate simplified and drawerLayout added
305f898
@pravinyo
DrawerLayout added
c67e7b9
@pravinyo
navigation drawer icons added
5d941ea
@pravinyo
hamburger navigation icon added
d98f601
@pravinyo
navigation header
eacbbe6
@pravinyo
navigation menu added
79e54d4
@pravinyo
string resource added
d1a9c11
@pravinyo
downloads icon removed from toolbar
31fdfce
@pravinyo
navigation item click implemented
3cbf04b
@pravinyo
kotlin version updated
87584a9
@pravinyo
settings module added
30f10bb
@pravinyo
settings module initial commit
69fae46
@pravinyo
settings module added
a0b81a9
@pravinyo
settings module intergrated with App
e2a6ac7
@pravinyo
settings module defined
17bc019
@pravinyo
preference library defined
69aea22
@pravinyo
Settings Preference Utils added
0b5c85f
@pravinyo
Settings Fragment added in graph
d866c16
@pravinyo
navigation to Settings fragment added
2092513
@pravinyo
Preference dependency added
7fac9bb
@pravinyo
implementation added for downloads path
b0bb6bc
@pravinyo
FileUtils for document
be42b39
@pravinyo
string resource added for downloads pref
f5d8cc8
@pravinyo
settings preference added
d57812d
@pravinyo
check from stored user folder path
93a9de9
@pravinyo
added handling for custom folder
27279f9
@pravinyo
extract folder from the uri and save it locally
d86b3a0
@pravinyo
moved to common
6dcb4b1
@pravinyo
added for downloads setting resource
afc834b
pravinyo added 24 commits May 10, 2020 18:18
@pravinyo
card view removed
275b065
@pravinyo
UI modified with new design
162921d
@pravinyo
border changed to white
1bf40c1
@pravinyo
hardcoded value replaced with dimen variable
e800f6f
@pravinyo
hardcoded value replaced with dimen variable
7bd0160
@pravinyo
resource updated
ca07353
@pravinyo
color count increased to 4
b9c3e6f
@pravinyo
bookmark and info icons added
9d6d53b
@pravinyo
icon changed
80d9551
@pravinyo
additional adapter added for book duration and chapter count
29918fa
@pravinyo
updated with new binding adapter
5e97b3a
@pravinyo
base ui fragment added
016aeaf
@pravinyo
extended BaseUIFragment for UI
5753cdb
@pravinyo
relative layout changed to coordinator layout
892bdf1
@pravinyo
dimen added for buttons
c907b58
@pravinyo
material library dependency added and toggle dependency removed
fe7c2be
@pravinyo
material dependency version updated
8e12c22
@pravinyo
Additional detail bottom sheet fragment added
5050db1
@pravinyo
viewModel shared with the fragment
406a311
@pravinyo
layout added for additional details fragment
27d1359
@pravinyo
margin top removed and height made wrap
f557836
@pravinyo
label resource added for publisher and book about
b16ad7b
@pravinyo
icon resource added for additional details fragment
e9d9bb7
@pravinyo
unused adapter removed
8e9864c
@pravinyo pravinyo merged commit b43793e into development May 11, 2020
@pravinyo pravinyo deleted the nav_drawer branch May 11, 2020 14:32
@pravinyo pravinyo restored the nav_drawer branch May 11, 2020 14:32
@pravinyo pravinyo mentioned this pull request May 15, 2020
Merged
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@pravinyo pravinyo

Labels
app issues related to app working bug Something isn't working enhancement New feature or request feature Feature related issue library issues related to core library
Projects
None yet
Milestone
enhancement-phase-1
Development

Successfully merging this pull request may close these issues.
1 participant
@pravinyo