Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 240: Remove Netty dependencies #241

Merged

Conversation

shshashwat
Copy link
Contributor

Signed-off-by: Shashwat Sharma shashwat_sharma@dell.com

Change log description
Remove forced netty version from build.gradle causing conflicts with Pravega higher versions

Purpose of the change
fixes #240

How to verify it
The build should pass and all existing test cases should complete successfully

Signed-off-by: Shashwat Sharma <shashwat_sharma@dell.com>
Copy link
Contributor

@kotlasaicharanreddy kotlasaicharanreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shshashwat
Copy link
Contributor Author

tested both versions of Pravega(0.10.2 and 0.11.0) with this change on live cluster. Performed a few set of operations(creating a schema, editing the schema, deleting the schema) and it worked fine.

@pbelgundi pbelgundi requested review from sachin-j-joshi and removed request for pbelgundi March 10, 2022 05:27
@shshashwat
Copy link
Contributor Author

@tkaitchuck, @sachin-j-joshi, @RaulGracia if you think we are good to go with the changes please take the next action else kindly provide your comment.

Copy link
Contributor

@RaulGracia RaulGracia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shshashwat, before merging, please check that building and running Schema Registry samples in Pravega Samples is working fine: https://github.com/pravega/pravega-samples

@RaulGracia RaulGracia changed the title Issue 240 remove netty dependencies Issue 240: Remove Netty dependencies Mar 15, 2022
@shshashwat
Copy link
Contributor Author

shshashwat commented Mar 22, 2022

Thanks @shshashwat, before merging, please check that building and running Schema Registry samples in Pravega Samples is working fine: https://github.com/pravega/pravega-samples

@RaulGracia, I tried this also and was able to test them all successfully. Thank you

@RaulGracia RaulGracia merged commit 188ca76 into pravega:master Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update build.gradle file to resolve netty issues
4 participants