Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fenwick trees in C++ #474

Merged
merged 2 commits into from
Oct 30, 2020
Merged

Fenwick trees in C++ #474

merged 2 commits into from
Oct 30, 2020

Conversation

cs-mshah
Copy link
Contributor

Description

Fenwick trees in C++ implemented with README.

Reference Issue number #468

Type of change

Choosing one or more options from the following as per the nature of your Pull request.

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have named my files and folder, according to this project's guidelines.
  • My code follows the style guidelines of this project.
  • My Pull Request has a descriptive title. (not a vague title like Update index.md)
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have created a helpful and easy to understand README.md, with problem description and my name.
  • My changes do not produce any warnings.

@cs-mshah
Copy link
Contributor Author

@pratik-choudhari I have made the PR according to the guidelines. Please check and accept the PR. I truly enjoyed contributing to this repository and taking part in the Hacktoberfest. Got to learn a lot!!

@pratik-choudhari
Copy link
Owner

@cs-mshah Thanks a lot! It was a pleasure having you :)

@pratik-choudhari pratik-choudhari merged commit 47992de into pratik-choudhari:master Oct 30, 2020
@cs-mshah
Copy link
Contributor Author

cs-mshah commented Nov 5, 2020

@pratik-choudhari my PR has been marked ineligible and I don't know why. The repo and the issue both have a hacktoberfest label. A previous PR on this same repo got accepted but this one is invalid.

@pratik-choudhari
Copy link
Owner

@cs-mshah Oh, that's weird. The repository is still labeled hacktoberfest.

@pratik-choudhari
Copy link
Owner

pratik-choudhari commented Nov 5, 2020

i have added another extra label let me know

@cs-mshah
Copy link
Contributor Author

cs-mshah commented Nov 5, 2020

I don't think anything is possible now. They've labelled it ineligible. They haven't even put any contact so I can tell them.

@pratik-choudhari
Copy link
Owner

@cs-mshah Ohh, did you make extra PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants