Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added EDA for StackOverflow 2019 Developer Dataset #449

Merged
merged 4 commits into from
Oct 25, 2020

Conversation

sanskritip
Copy link
Contributor

@sanskritip sanskritip commented Oct 22, 2020

Description

A comprehensive description about the Pull Request

Reference Issue number #162

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation Update

Checklist:

  • I have named my files and folder, according to this project's guidelines.
  • My code follows the style guidelines of this project.
  • My Pull Request has a descriptive title. (not a vague title like Update index.md)
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have created a helpful and easy to understand README.md, with problem description and my name.
  • I have included a requirements.txt file (if external libraries are required.)
  • My changes do not produce any warnings.
  • I have starred this repository.
  • I have added a working sample/screenshot of the script.
  • I have checked for trailing spaces in file names and none have them.

@pratik-choudhari
Copy link
Owner

@sanskritip You have made a draft PR

@sanskritip
Copy link
Contributor Author

@sanskritip You have made a draft PR

Hey I'll just add requirements.txt and un-draft it by tonight!

@sanskritip sanskritip marked this pull request as ready for review October 24, 2020 11:06
@pratik-choudhari
Copy link
Owner

@sanskritip Did you pip freeze and add it to requirements? because those are a lot of dependencies.

@sanskritip
Copy link
Contributor Author

@sanskritip Did you pip freeze and add it to requirements? because those are a lot of dependencies.

Yes, I did pip freeze in the virtual environment. A lot of the libraries used come with added dependencies which is kind of the reason for the large number. Is it an issue ?

@pratik-choudhari
Copy link
Owner

@sanskritip Yes, it is an issue. Those package versions might make a lot of other packages deprecated. Just include the packages which you have used and don't come preinstalled with python.

@sanskritip
Copy link
Contributor Author

@sanskritip Yes, it is an issue. Those package versions might make a lot of other packages deprecated. Just include the packages which you have used and don't come preinstalled with python.

Made the required changes! Thank you for pointing them out!

@pratik-choudhari pratik-choudhari merged commit 7087d17 into pratik-choudhari:master Oct 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants