Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QR Code Scanner Web Application #164

Merged
merged 14 commits into from
Jun 13, 2021
Merged

Conversation

triposat
Copy link
Contributor

@triposat triposat commented Jun 12, 2021

  • LGM-SOC'21 Participant
  • Contributor

Closes: #126

Describe the changes you've made

This Python script uses the Pillow module to scan a QR code, decode it with pyzbar, and display the web result using pywebio.

Type of change

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

I have tested this code in my local machine.

Describe how have you verified the changes made

Checklist:

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented on my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Screenshots

hey

Copy link
Owner

@prathimacode-hub prathimacode-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to be done

  • Add all the libraries imported in "requirements.txt" file
  • Elaborate the README file.
  • The images and screenshots should be in "Images" folder.
  • The image link you added in README file of the project is user-images. Add the image link that's added up in the epository.

Kindly do the needful changes. @Iamtripathisatyam

@prathimacode-hub prathimacode-hub added the LGMSOC21 This issue will be considered for LGM-SOC 21 label Jun 12, 2021
Copy link
Owner

@prathimacode-hub prathimacode-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to be done:

Elaborate the README file. Add steps to compile and aim of the project.
The image link you added in README file of the project is user-images. Add the image link that's added up in this repository.

Kindly do the needful changes. @Iamtripathisatyam

@triposat
Copy link
Contributor Author

Ma'am, please explain the second point i.e. Image point, I am not getting that

Copy link
Owner

@prathimacode-hub prathimacode-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your PR is approved. Congo. Keep up your amazing work. 👏 @Iamtripathisatyam

@prathimacode-hub prathimacode-hub added the 🟨 Level2 This issue will be considered as level 2 issue for LGM-SOC 21 & DCP21. label Jun 13, 2021
@prathimacode-hub prathimacode-hub merged commit 5c05194 into prathimacode-hub:main Jun 13, 2021
@prathimacode-hub prathimacode-hub added 🟩 Level1 This issue will be considered as level 1 issue for LGM-SOC 21 & DCP21.Points will be 10 and removed 🟨 Level2 This issue will be considered as level 2 issue for LGM-SOC 21 & DCP21. labels Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🟩 Level1 This issue will be considered as level 1 issue for LGM-SOC 21 & DCP21.Points will be 10 LGMSOC21 This issue will be considered for LGM-SOC 21
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QR Code Scanner
2 participants