Skip to content

improving translation support#1404

Open
zedzhen wants to merge 2 commits into
prasathmani:masterfrom
zedzhen:more-translate
Open

improving translation support#1404
zedzhen wants to merge 2 commits into
prasathmani:masterfrom
zedzhen:more-translate

Conversation

@zedzhen

@zedzhen zedzhen commented May 19, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@zedzhen

zedzhen commented May 21, 2026

Copy link
Copy Markdown
Contributor Author

@prasathmani I have resolved the merge conflict.

@Maikuolan Maikuolan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Splitting up the translation into parts like that could be problematic for some languages, because not all languages follow the same word order. Let's assume the phrase, "Copied from x to z".

English generally uses the SVO word order, and these changes wouldn't be problematic for any other languages using generally the same word order, like in Italian, "Copiato da x a z", in Portuguese, "Copiado de x a z", etc.

But languages like Japanese, Persian, or Hindi, for example, generally use the SOV word order, e.g., "xからzにコピーされました" in Japanese, "از x به z کپی شده است" in Persian, "x से z तक कॉपी किया गया" in Hindi, etc. Forcing them to conform to SVO could produce weird results, e.g., for Hindi, we'd likely end up with something like "से कॉपी किया गया x को z", which would look clunky and jarring to a native reader.

There are many other ways sentences can be structured across different languages, too. To account for those differences, it would be better to keep the original Copied from <b>%s</b> to <b>%s</b> rather than splitting it up.

Edit: My review is in relation to the change at L817. I'm not sure why my review didn't automatically link to the relevant line, as I did click on it specifically to trigger the review form to appear, rather than just clicking the general submit review button. Page must've glitched out or something, I guess. Anyway, attaching manually now:

-               fm_set_msg(sprintf('Copied from <b>%s</b> to <b>%s</b>', fm_enc($copy), fm_enc($fn_duplicate)));
+               fm_set_msg(sprintf(lng('Copied from').' <b>%s</b> '.lng('to').' <b>%s</b>', fm_enc($copy), fm_enc($fn_duplicate)));

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants