Fix locale that does not have plural form#8
Open
arrizalamin wants to merge 1 commit intoprantlf:combinedfrom
Open
Fix locale that does not have plural form#8arrizalamin wants to merge 1 commit intoprantlf:combinedfrom
arrizalamin wants to merge 1 commit intoprantlf:combinedfrom
Conversation
arrizalamin
force-pushed
the
fix-indonesian-locale
branch
from
f830181 to
bfa1af4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently there is a bug with Indonesian locale since this library uses plural rules and Indonesian doesn't have plural form (though we could use
se-to replace 1, likesehariinstead of1 hari). This caused relativeTime plugin to always use singular formsehari (1 day)when it should be%d hariif the number is more than 1.