Improvement: Speed up public organization enumeration #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the core problems highlighted in #44
For large public organization enum, Gato will now only perform run log analysis if repositories pass a heuristic based on workflow analysis. Additionally, Gato will use the GraphQL API to download all workflow ymls and cache them before enumerating individual repositories.
Additionally, Gato will be more selective with the run logs it downloads to avoid downloading duplicate logs for the same workflow file and trigger. Furthermore, I've added a new heuristic that will determine whether a self-hosted runner is ephemeral. The heuristic works by looking for the clean repository step in the output for
actions/checkout. Note, this is a heuristic, and it may be subject to false positives (rare, but possible in limited scenarios with caching), or false negatives (more likely).With these changes, you can run Gato against a large organization like Microsoft within a reasonable time. This supports continuous testing and monitoring use cases as more organizations become aware of the dangers of self-hosted runner misconfigurations.