Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update and run pre-commit on CI #21

Merged
merged 3 commits into from
Oct 15, 2020
Merged

Update and run pre-commit on CI #21

merged 3 commits into from
Oct 15, 2020

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Oct 15, 2020

I noticed pre-commit was currently failing.

This PR updates pre-commit, runs it to make changes, and runs it on the CI to make sure it remains fixed.

@hugovk hugovk changed the title Update and pre-commit on CI Update and run pre-commit on CI Oct 15, 2020
pradyunsg
pradyunsg requested changes Oct 15, 2020
View reviewed changes
Copy link
Owner

@pradyunsg pradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre-commit updates look great! Inline request for changing CI.

.github/workflows/lint.yml Outdated Show resolved Hide resolved
@pradyunsg pradyunsg merged commit 8e7e829 into pradyunsg:main Oct 15, 2020
@hugovk hugovk deleted the update-pre-commit branch October 15, 2020 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pradyunsg pradyunsg pradyunsg requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hugovk @pradyunsg