Remove the recently added nvd alias #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. I am going to leave the security/nvd alias there for a couple of weeks, so people have time to look at it. Once I've added this tool to the book I'll merge the PR. |
practicalli-johnny
force-pushed
the
live
branch
from
533b13c to
c41692e
Compare
On advice from the clojure-nvd project maintainer, using clojure-nvd from an alias is not recommended. The clojure-nvd library itself would be included in the security check and potentially create false positives Mark the :security/nvd alias as deprecated and add warning to README
practicalli-johnny
force-pushed
the
remove-nvd
branch
from
9ad6b01 to
3113fa8
Compare
|
I am going to leave the :security/nvd alias as deprecated for the present time, rather than simply remove it. It will help highlight the potential for false positives in using clojure-nvd with a Clojure CLI alias. I've updated the pull request accordingly (which also gave me chance to remember how to do that in Magit :) ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #31 for reasons and discussion.
This PR completely removes the alias and the documentation. EDIT: refactored to mark the
:security/nvdalias as deprecated as there is potential for false positives from the clojure-nvd library being included on the classpath