Support multi-root workspaces

[ipkiss42]

This is more or less the same as #157: please add support for multi-root workspaces.

Since Vim does not provide support for workspaces, I think the best (and only?) approach is to support it at the LS client level, i.e. vim-lsp. This could be as simple as supporting a global variable (e.g. g:WorkspaceFolders) containing a list of root folders.

FYI, this is how coc.nvim does it: https://github.com/neoclide/coc.nvim/wiki/Using-workspaceFolders

[prabirshrestha]

Waiting on reply for this first.

vim/vim#7748

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[ipkiss42]

@prabirshrestha: it looks like the Vim issue itself is stale. What is the path forward on this topic?

[dezza]

I'm looking into trying to run multiple servers so you can edit multiple projects at once in the same session but with different root_uri and instead servers are then looked up by root_uri and not filetype/server_name.

I just want LSP functions to persist between multiple projects of same filetype
(currently the first root_uri sticks and only way to switch between projects is kill server first then open the new project to re-initialize it with new root_uri)

I can run 2 gopls servers with different root_uri, but I also receive response from both at the moment (locationlist opens with 2 results for goto-definition for example) so I will have to look into adapting that code as well.

I hope its possible :)

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[ipkiss42]

@prabirshrestha I think the stale bot is pinging you :)

[dezza]

dezza@6d06793

dezza/vim-lsp-settings@6c9ecc0

autocmd BufEnter *.go source ~/.vim/pack/voom/start/vim-lsp-settings/settings/gopls.vim
autocmd BufRead * call lsp#enable()
autocmd VimEnter * call lsp_settings#init()

I did something like this back when I got multiple servers per root_uri working - naming each server with their root_uri. The most cumbersome is enabling the lsp server as vim-lsp assumes one server and the same for terminating the servers. The servers are terminated fine when you :bdelete a buffer as far as I remember, but there might be other cases it doesn't as I saw a few servers spawned. Another caveat to this is that it starts another server for every goto-definition for imported stdlibs which I didn't see an obvious way to fix (How to tell if its a stdlib that can be resolved by same server? Or how to tell if its NOT a stdlib?)

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[dezza]

I haven't had time to finish this, I don't know this project well enough to know what parts it would affect without trial and error.

But it is #1 reason my friends are staying on coc.nvim which does something similar.

The goto-definition question seems to be the hardest to get right (only start a new server if its not a stdlib where you can reuse any server really)

vim-lsp has assumption of 1 server per language.