Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few additional things I missed #67

Closed
wants to merge 3 commits into from
Closed

Conversation

EliteTK
Copy link
Contributor

@EliteTK EliteTK commented Jun 4, 2024

I forgot about some of the documentation/changelog updates.

I also missed something clippy complained about, but there was something else it wanted to fix so I rolled it into one commit (can always split if you want).

@EliteTK
Copy link
Contributor Author

EliteTK commented Jun 4, 2024

ah, you already added to the changelog, let me drop that change then

@pr2502
Copy link
Owner

pr2502 commented Jun 4, 2024

i did the clippy thing and readme as well, sorry 😅

btw have you tried the neovim unix socket option? i'm running the proxy over a unix socket now from helix and it works great but i don't have a functional neovim setup to test the config example you pushed

@EliteTK
Copy link
Contributor Author

EliteTK commented Jun 4, 2024

Okay, I dropped the changelog change from the commits. Feel free to drop anything else you don't like.

Also, thanks for this project. I really like it, makes it much more pleasant to use neovim with rust-analyser!

@EliteTK
Copy link
Contributor Author

EliteTK commented Jun 4, 2024

i did the clippy thing and readme as well, sorry 😅

btw have you tried the neovim unix socket option? i'm running the proxy over a unix socket now from helix and it works great but i don't have a functional neovim setup to test the config example you pushed

Ah, okay, no worries. I can drop the rest or you can just cherry pick the one commit you want.

Yes, I am currently running that example:

image

@pr2502
Copy link
Owner

pr2502 commented Jun 4, 2024

i've cherry-picked the neovim example and the second clippy fix to main. closing this. thank you:)

@pr2502 pr2502 closed this Jun 4, 2024
@EliteTK EliteTK deleted the fixes branch June 4, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants