Include /etc/rc.subr, required for wait_for_pids #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey thanks! I've got some other PR's queued for merging, but expect this to be merged soon ™️ |
|
Please note that we have moved major functions into libraries, thus creating conflicts for this PR. Does this need to be kept where the |
added 3 commits
May 2, 2016 09:45
This reverts commit 53c7576.
* master: add freenas handbook link for tunables add bridge and tap modules at kmod time Add linebreak after iohyve command Adapt README and manpage to help output change Make setup help more zfsish Change help to distinguish mandatory parameters Enable copying of lib in Makefile Move functions from 'iohyve' into lib folder
|
I would personally load it before including the own library files. Not sure but something tells me that you are going to use the wait_for_pids more often. But indeed, for now, in the |
|
Thanks for working on this! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #154