Change help to distinguish mandatory parameters from optional parameters #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the help output to a 'zfs' command style output, where mandatory parameters are in angle brackets and optional parameters in brackets.
Closed
|
The setup command is kind of strange, because it can have any combination of the arguments (pool, net and/or kmod) but should require at least one of them. I am not quite sure how to express that. |
|
This looks good, and you handle the You can read how we turn the Also note, I am going to try and get your library move merged before merging this PR. Keep up the good work! 👍 |
|
Looking good 😎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the help output to a 'zfs' command style output,
where mandatory parameters are in angle brackets and optional
parameters in brackets.