Add current stage overlay to ranked play#37202
Merged
peppy merged 5 commits intoppy:masterfrom Apr 5, 2026
Merged
Conversation
Displays the stage name and details like currently picking player and damage multiplayer where applicable. Currently only shown on the discard and pick stages.
LiquidPL
commented
Apr 4, 2026
| /// Heading text to be displayed indicating the purpose of the current stage. | ||
| /// </summary> | ||
| protected abstract LocalisableString StageHeading { get; } | ||
| public abstract LocalisableString StageHeading { get; } |
Contributor
Author
There was a problem hiding this comment.
I'm not the biggest fan of this.
An alternative could be having something like a CreateStageOverlay in RankedPlaySubScreen, however that would require the subscreens (well, just PickScreen/OpponentPicksScreen to be honest) to have access to the APIUsers in order to pass it to the overlay component, which I feel would make this more messy.
peppy
approved these changes
Apr 5, 2026
peppy
approved these changes
Apr 5, 2026
This was referenced Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Displays the stage name and details like currently picking player
and damage multiplayer where applicable.
Currently only shown on the discard and pick stages.
Move user retrieval to
RankedPlayScreenThis is done because I need the relevant
APIUserinstances in order to pass them to the overlay component.RankedPlayScreenseems like the appropriate place to manage the overlays since it manages the stage subscreens, hence the need to access theAPIUsers in here.Add current stage overlay to ranked play
The actual change of this PR. Very much a dev design.
Screencast_20260404_162046.mp4