Merged
Conversation
…ers (and hopefully no longer flake) As seen in https://github.com/ppy/osu/actions/runs/23890777748#user-content-r3s3. This is a speculative fix but I'm feeling somewhat confident about this one. `BeatmapLeaderboardWedge` has TWO separate `ContextMenuContainer` itself, and the test mentioned here was bringing a third. I have a feeling that the test flaking may have something to do with the fact that the test logic would attempt to click a menu item on specifically ONE of the three context menus. My bet is that when it fails, it's because it's trying the wrong one, but I don't have reproduction.
…tSelectableMouseHandling` test As seen in https://github.com/ppy/osu/actions/runs/23888446400#user-content-r1s1. Speculative. Banking on the fact that it takes time to load the sprite texts.
…xistence of wiki on dev Deletes a flaky as seen in https://github.com/ppy/osu/actions/runs/23878899702#user-content-r2s2. The year is 2026 and LLM scrapers hammer the entire internet all over to scrape whatever ounce of Human Content there is left to feed the Moloch so that it can regurgitate it back in the form of The Most Average Speech You've Ever Read. We are not immune to this, and as such the LLM homunculi have hit the dev.ppy.sh wiki instance enough times for it to just completely be banished to the blagole. Which means I get to freely delete flaky tests that should never have been running as part of CI because they're completely useless now and it's not like we're ever turning them back on again.
…sitionMaintainedOnRemove_SecondSelected` that's less sensitive to floating point As seen in https://github.com/ppy/osu/actions/runs/23826420794#user-content-r0s1.
bdach
added
the
area:test coverage
peppy
approved these changes
Apr 3, 2026
This was referenced Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few quick ones from #37190.
Rewrite
TestSceneDeleteLocalScoreto have less context menu containers (and hopefully no longer flake)As seen in https://github.com/ppy/osu/actions/runs/23890777748#user-content-r3s3.
This is a speculative fix but I'm feeling somewhat confident about this one.
BeatmapLeaderboardWedgehas TWO separateContextMenuContainers itself, and the test mentioned here was bringing a third. I have a feeling that the test flaking may have something to do with the fact that the test logic would attempt to click a menu item on specifically ONE of the three context menus. My bet is that when it fails, it's because it's trying the wrong one, but I don't have reproduction.Wait for text to appear in flaking
TestSceneDrawableRoomPlaylist.TestSelectableMouseHandlingtestAs seen in https://github.com/ppy/osu/actions/runs/23888446400#user-content-r1s1.
Speculative. Banking on the fact that it takes time to load the sprite texts.
Remove all tests from
TestSceneWikiMarkdownContainerdependent on existence of wiki on devDeletes a flaky as seen in https://github.com/ppy/osu/actions/runs/23878899702#user-content-r2s2.
The year is 2026 and LLM scrapers hammer the entire internet all over to scrape whatever ounce of Human Content there is left to feed the Moloch so that it can regurgitate it back in the form of The Most Average Speech You've Ever Read. We are not immune to this, and as such the LLM homunculi have hit the dev.ppy.sh wiki instance enough times for it to just completely be banished to the blagole.
Which means I get to freely delete flaky tests that should never have been running as part of CI because they're completely useless now and it's not like we're ever turning them back on again.
Use equality check in
TestSceneBeatmapCarouselScrolling.TestScrollPositionMaintainedOnRemove_SecondSelectedthat's less sensitive to floating pointAs seen in https://github.com/ppy/osu/actions/runs/23826420794#user-content-r0s1.