Merged
Conversation
It's been semi-broken since I bumped it a few weeks ago. Paper trail for this is at dorny/test-reporter#750, but to TL;DR it: dorny/test-reporter@v2.0.0 migrated from creating new check runs via the GitHub API (https://docs.github.com/en/rest/checks/runs) to job summaries (https://docs.github.com/en/actions/reference/workflows-and-actions/workflow-commands#adding-a-job-summary) by default. The main difference is that compared to check runs, job summaries do not *appear to* require extra `GITHUB_TOKEN` permissions, but in exchange are limited to the job that called it. This broke visibility of the test reports because due to `GITHUB_TOKEN` permissions foibles the test reporter was running in a separate workflow. I see migrating as a plus here, since: - The visibility of results is comparable-to-better (example available for preview at https://github.com/bdach/osu/actions/runs/23892493152) - No longer required to have a completely separate workflow for test result reporting - No longer required to give `checks: write` permissions to the action (I'd hope, we'll see) One downside is there'll be no in-code annotations for failing tests anymore but that's whatever IMO. Half the time they weren't even very helpful, test results pretty much require maintainer interpretation anyway. This needs to be applied to a few other repos but I'm starting here because this is the one where the traffic is highest and therefore unbreaking the report is of most value. Side note, I was hoping to remove the artifact upload/download games by just attaching the summary inside each individual test job in the matrix, but it looks like crap (https://github.com/bdach/osu-framework/actions/runs/23888384309) because only the first three summaries are loaded by default, so if there are more, you have to click each remaining one to see its output. Wow. Awesome.
peppy
approved these changes
Apr 2, 2026
github-project-automation
bot
moved this from Pending Review
to Done
in osu! team task tracker
This was referenced Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adjust CI test reporting to upstream action changes
It's been semi-broken since I bumped it a few weeks ago. Paper trail for this is at dorny/test-reporter#750, but to TL;DR it:
dorny/test-reporter@>=v2.0.0migrated from creating new check runs via the GitHub API to job summaries by default.The main difference is that compared to check runs, job summaries do not appear to require extra
GITHUB_TOKENpermissions, but in exchange are limited to the job that called it. This broke visibility of the test reports because due toGITHUB_TOKENpermissions foibles the test reporter was running in a separate workflow.I see migrating as a plus here, since:
checks: writepermissions to the action (I'd hope, we'll see, untested on a public repository with PRs involved)One downside is there'll be no in-code annotations for failing tests anymore but that's whatever IMO. Half the time they weren't even very helpful, test results pretty much require maintainer interpretation anyway.
This needs to be applied to a few other repos but I'm starting here because this is the one where the traffic is highest and therefore unbreaking the report is of most value (and also the one where I'll see if it works with public PRs the fastest).
Side note, I was hoping to remove the artifact upload/download games by just attaching the summary inside each individual test job in the matrix, but it looks like crap because only the first three summaries are loaded by default, so if there are more, you have to click each remaining one to see its output. Wow. Awesome.
Also updates the action to
v3.0.0to resolve node deprecation warnings.Update inspectcode version to resolve deprecation warnings
More node deprecation warning fixes.