Implement background music for ranked play#37166
Merged
peppy merged 14 commits intoppy:masterfrom Apr 2, 2026
Merged
Conversation
peppy
reviewed
Apr 2, 2026
| [BackgroundDependencyLoader] | ||
| private void load(AudioManager audio, OsuGameBase game) | ||
| { | ||
| // workaround to play BGM through `TrackMixer` instead of `SampleMixer`, so it inherits players' music volume settings, etc. |
Member
There was a problem hiding this comment.
This is just because the track isn't in the Tracks folder right? I'm not sure why it's not in that folder, was there a reason for this?
Update resources
peppy
approved these changes
Apr 2, 2026
Member
peppy
left a comment
peppy
left a comment
There was a problem hiding this comment.
Probably fine as an initial pass
This was referenced Apr 6, 2026
This was referenced Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using a bespoke music loop, fades in during the intro:
bgm_intro.mov
Ducks when hovering cards for previews, with debouncing to smooth it:
bgm_duck.mov