Fix song select dropdowns not being navigable with keyboard#37158
Fix song select dropdowns not being navigable with keyboard#37158peppy merged 3 commits intoppy:masterfrom
Conversation
| // disable the framework-level handling of up and down key for conformity (we use GlobalAction.SelectPrevious and SelectNext). | ||
| if (e.Key == Key.Up || e.Key == Key.Down) | ||
| return false; |
There was a problem hiding this comment.
Is there a good reason to disable this rather than just let it work as well?
There was a problem hiding this comment.
Nope, I was just followingFocusedTextBox.
There was a problem hiding this comment.
Not sure how much I agree with that, so let's maybe just not do it for now. I can't imagine a scenario where a user would expect up and down to not traverse items.
There was a problem hiding this comment.
Sure, but osu!-specific item flow implementations, as I mentioned in the PR description, are only using global actions with no fallback of hardcoded up and down. Out of scope but something to think about / apply later.
I'll just keep the framework-level handling to keep things going, doesn't seem to conflict with anything.
2 participants
Uses the global action variant of up and down for dropdown menus. It is already used in multiplayer/playlist room/beatmap navigation and gameplay menu overlays.
Comment wording is derived from:
osu/osu.Game/Graphics/UserInterface/FocusedTextBox.cs
Lines 73 to 74 in fc81762