Refactor SnapAimEvaluator bonuses for better readability#37119
Merged
tsunyoku merged 4 commits intoppy:pp-devfrom Apr 12, 2026
Merged
Refactor SnapAimEvaluator bonuses for better readability#37119tsunyoku merged 4 commits intoppy:pp-devfrom
tsunyoku merged 4 commits intoppy:pp-devfrom
Conversation
stanriders
reviewed
Apr 1, 2026
osu.Game.Rulesets.Osu/Difficulty/Evaluators/Aim/SnapAimEvaluator.cs
Outdated
Show resolved
Hide resolved
tsunyoku
approved these changes
Apr 12, 2026
github-project-automation
bot
moved this to Pending Deploy
in Difficulty calculation changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves the addition of the bonuses closer to their declaration and also renames some variables and functions to more closely resemble the way they're used. The names can be discussed for I'm not sold on them either.