Skip to content

Add warning display when player loading is paused due to user interaction#37091

Merged
peppy merged 4 commits intoppy:masterfrom
peppy:loading-pause-warning
Mar 25, 2026
Merged

Add warning display when player loading is paused due to user interaction#37091
peppy merged 4 commits intoppy:masterfrom
peppy:loading-pause-warning

Conversation

@peppy
Copy link
Copy Markdown
Member

@peppy peppy commented Mar 25, 2026

As touched on in #37082.

15 minute task fixing a UX which was definitely not as visible as it should have been.

osu.2026-03-25.at.07.28.49.mp4

…tion

As touched on in ppy#37082.

15 minute task fixing a UX which was definitely not as visible as it
should have been.
@bdach
Copy link
Copy Markdown
Collaborator

bdach commented Mar 25, 2026

Weird behaviours that might be blockers:

The warning display always shows briefly just before loading into the game if you tab out of the game

Screen.Recording.2026-03-25.at.09.34.31.mov

Likely happens because the IsHovered checks all fail due to being tabbed out, until idleTracker kicks in after 1.5s to kick the player into ReadyForGameplay state

The warning display shows briefly on every multiplayer game start

Screen.Recording.2026-03-25.at.09.34.59.mov

Probably corresponds to the RTT between the client notifying the server it's loaded player, and the server acknowledging receipt of that notification.

@peppy
Copy link
Copy Markdown
Member Author

peppy commented Mar 25, 2026

I almost think loading should be blocked as long as the game doesn't have focus.

For the multiplayer case, I guess we can delay the animation a bit to avoid in most cases?

@peppy peppy force-pushed the loading-pause-warning branch from acabdbb to b2309a9 Compare March 25, 2026 09:12
@bdach
Copy link
Copy Markdown
Collaborator

bdach commented Mar 25, 2026

I almost think loading should be blocked as long as the game doesn't have focus.

I tend to agree but fixing this is probably out of scope here. I'm just mentioning things you might not be okay with before someone else does in five separate issues tomorrow 🤷

Copy link
Copy Markdown
Collaborator

@bdach bdach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe fine 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants