Fix timing points sometimes not showing up in the editor timeline when paired with a kiai start/end#37061
Merged
peppy merged 1 commit intoppy:masterfrom Mar 22, 2026
Merged
Conversation
…eline when EffectControlPoint is positioned before it in the control point group
peppy
approved these changes
Mar 22, 2026
MingxuanGame
pushed a commit
to GooGuTeam/osu
that referenced
this pull request
Mar 29, 2026
…n paired with a kiai start/end (ppy#37061) Initially reported on [discord](https://discord.com/channels/188630481301012481/1097318920991559880/1481649645167054878). `return` instead of `continue` led to the loop exiting too early if there was an `EffectControlPoint` in the list before a `TimingControlPoint`. Behaviour can be reproduced with topdiff on this [mapset](https://osu.ppy.sh/beatmapsets/1884175#osu/4027941). When opened, all timing points on kiai start don't show up in the timeline. If you disable/enable the effects section on one of those timing points the order changes and it becomes visible again.
This was referenced Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initially reported on discord.
returninstead ofcontinueled to the loop exiting too early if there was anEffectControlPointin the list before aTimingControlPoint.Behaviour can be reproduced with topdiff on this mapset. When opened, all timing points on kiai start don't show up in the timeline. If you disable/enable the effects section on one of those timing points the order changes and it becomes visible again.