Fix editor background taking too long to load with certain storyboards#37038
Merged
bdach merged 4 commits intoppy:masterfrom Mar 23, 2026
Merged
Fix editor background taking too long to load with certain storyboards#37038bdach merged 4 commits intoppy:masterfrom
bdach merged 4 commits intoppy:masterfrom
Conversation
TL;DR the clock was being set too late, causing more transforms to be created than necessary. This solves the issue by way of a refactor (sorry). Overall this should simplify handling of things as more of the logic is shared with the known good-state `BeatmapBackgroundWithStoryboard`. Of note, I removed the black background overdraw hack. There are edge cases where it will lead to weird transitions, but these are far and few between. Basically you need a storyboard which sets the flag to hide the beatmap background and has transparency in it. This is no longer as flagrantly bad as things used to be (which led to the inline fix) as far as I can tell, but feel free to prove me wrong. Closes ppy#36875.
bdach
reviewed
Mar 19, 2026
Collaborator
|
This has some pretty horrible visual issues with transitions, both on editor entry and exit: Screen.Recording.2026-03-19.at.12.37.09.mov
|
Member
Author
|
The ultra wide reveals all 😅 I'll add a black box for now yeah? |
Collaborator
|
Probably easiest at this stage. |
Member
Author
|
Please check that the updated code has fixed both your weird scenarios. |
bdach
reviewed
Mar 23, 2026
bdach
approved these changes
Mar 23, 2026
bdach
added a commit
to bdach/osu
that referenced
this pull request
Mar 26, 2026
…ackground is disabled Man this "storyboard replaces background" baloney has taken hours of bugfixing alone. So many forehead indentations from stepping onto this stupid rake. This still fails in one more case: when you download a no-video variant of a beatmap that has video, but then edit it, all of the flags checked here will claim that the beatmap has a storyboard that replaces a background, but the video asset is missing, so the background will still be black. There's currently no way to check for this and the simplest way to address this as far as I can see would be reverting ppy#37038 and going with the non-refactor route to fix ppy#36875 instead.
bdach
added a commit
to bdach/osu
that referenced
this pull request
Mar 26, 2026
…eplace background is disabled Man this "storyboard replaces background" baloney has taken hours of bugfixing alone. So many forehead indentations from stepping onto this stupid rake. This still fails in one more case: when you download a no-video variant of a beatmap that has video, but then edit it, all of the flags checked here will claim that the beatmap has a storyboard that replaces a background, but the video asset is missing, so the background will still be black. There's currently no way to check for this and the simplest way to address this as far as I can see would be reverting ppy#37038 and going with the non-refactor route to fix ppy#36875 instead.
peppy
pushed a commit
that referenced
this pull request
Mar 27, 2026
…eplace background is disabled (#37112) Man this "storyboard replaces background" baloney has taken hours of bugfixing alone. So many forehead indentations from stepping onto this stupid rake. This still fails in one more case: when you download a no-video variant of a beatmap that has video, but then edit it, all of the flags on storyboard will claim that the beatmap has a storyboard that replaces a background, but the video asset is missing, so the background will still be black. There's currently no way to check for this and the simplest way to address this as far as I can see would be reverting #37038 and going with the non-refactor route to fix #36875 instead. The alternative is adding all sorts of weird jingles and checks in the storyboard machinery that can be used to be able to tell that a video was supposed to be present in the storyboard but is missing. Also when entering editor on a map that has background video and storyboard enabled the background will be black until you hit play. Something to do with `Video` idiosyncrasies for sure. Closes #37104 maybe? Kind of? Partially? I don't know. This is all very low effort because I'm not confident about digging this ditch any deeper, but just PRing a direct revert would feel pretty offensive I guess?
MingxuanGame
pushed a commit
to GooGuTeam/osu
that referenced
this pull request
Mar 29, 2026
ppy#37038) TL;DR the clock was being set too late, causing more transforms to be created than necessary. This solves the issue by way of a refactor (sorry). Overall this should simplify handling of things as more of the logic is shared with the known good-state `BeatmapBackgroundWithStoryboard`. I did try without a refactor (just delaying the creation until the clock arrives) but this version made more sense because background generally expect to do their main load in BDL to aid in smooth transitions. And we can't get the clock by there. (although arguably we could just use a similar method to `BeatmapBackgroundWithStoryboard` and forego using the editor clock). Of note, I removed the black background overdraw hack. There are edge cases where it will lead to weird transitions, but these are far and few between. Basically you need a storyboard which sets the flag to hide the beatmap background and has transparency in it. This is no longer as flagrantly bad as things used to be (which led to the inline fix) as far as I can tell, but feel free to prove me wrong. If this is a blocker I'll probably just add a permanent black box (which does fix this). Closes ppy#36875.
MingxuanGame
pushed a commit
to GooGuTeam/osu
that referenced
this pull request
Mar 29, 2026
…eplace background is disabled (ppy#37112) Man this "storyboard replaces background" baloney has taken hours of bugfixing alone. So many forehead indentations from stepping onto this stupid rake. This still fails in one more case: when you download a no-video variant of a beatmap that has video, but then edit it, all of the flags on storyboard will claim that the beatmap has a storyboard that replaces a background, but the video asset is missing, so the background will still be black. There's currently no way to check for this and the simplest way to address this as far as I can see would be reverting ppy#37038 and going with the non-refactor route to fix ppy#36875 instead. The alternative is adding all sorts of weird jingles and checks in the storyboard machinery that can be used to be able to tell that a video was supposed to be present in the storyboard but is missing. Also when entering editor on a map that has background video and storyboard enabled the background will be black until you hit play. Something to do with `Video` idiosyncrasies for sure. Closes ppy#37104 maybe? Kind of? Partially? I don't know. This is all very low effort because I'm not confident about digging this ditch any deeper, but just PRing a direct revert would feel pretty offensive I guess?
This was referenced Apr 6, 2026
This was referenced Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR the clock was being set too late, causing more transforms to be created than necessary.
This solves the issue by way of a refactor (sorry). Overall this should simplify handling of things as more of the logic is shared with the known good-state
BeatmapBackgroundWithStoryboard.I did try without a refactor (just delaying the creation until the clock arrives) but this version made more sense because background generally expect to do their main load in BDL to aid in smooth transitions. And we can't get the clock by there. (although arguably we could just use a similar method to
BeatmapBackgroundWithStoryboardand forego using the editor clock).Of note, I removed the black background overdraw hack. There are edge cases where it will lead to weird transitions, but these are far and few between. Basically you need a storyboard which sets the flag to hide the beatmap background and has transparency in it. This is no longer as flagrantly bad as things used to be (which led to the inline fix) as far as I can tell, but feel free to prove me wrong. If this is a blocker I'll probably just add a permanent black box (which does fix this).
Closes #36875.