Ranked Play: Fix casing inconsistency in results screen#36931
Merged
peppy merged 1 commit intoppy:masterfrom Mar 11, 2026
Merged
Ranked Play: Fix casing inconsistency in results screen#36931peppy merged 1 commit intoppy:masterfrom
peppy merged 1 commit intoppy:masterfrom
Conversation
peppy
approved these changes
Mar 11, 2026
This was referenced Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is kind of annoying...
Some hit results are given custom names (e.g. "slider tick"):
osu/osu.Game.Rulesets.Osu/OsuRuleset.cs
Lines 301 to 320 in 87b37fd
While others go through that
basecall which uses the enum descriptions (e.g. "Great"):osu/osu.Game/Rulesets/Scoring/HitResult.cs
Lines 53 to 56 in 87b37fd