Skip to content

Ranked Play: Fix casing inconsistency in results screen#36931

Merged
peppy merged 1 commit intoppy:masterfrom
smoogipoo:rp-fix-casing-inconsistency
Mar 11, 2026
Merged

Ranked Play: Fix casing inconsistency in results screen#36931
peppy merged 1 commit intoppy:masterfrom
smoogipoo:rp-fix-casing-inconsistency

Conversation

@smoogipoo
Copy link
Copy Markdown
Contributor

This is kind of annoying...

Some hit results are given custom names (e.g. "slider tick"):

public override LocalisableString GetDisplayNameForHitResult(HitResult result)
{
switch (result)
{
case HitResult.LargeTickHit:
return "slider tick";
case HitResult.SliderTailHit:
case HitResult.SmallTickHit:
return "slider end";
case HitResult.SmallBonus:
return "spinner spin";
case HitResult.LargeBonus:
return "spinner bonus";
}
return base.GetDisplayNameForHitResult(result);
}

While others go through that base call which uses the enum descriptions (e.g. "Great"):

[Description(@"Great")]
[EnumMember(Value = "great")]
[Order(1)]
Great,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants