Add replay / spectator mode scrolling text back#36911
Merged
bdach merged 5 commits intoppy:masterfrom Mar 11, 2026
Merged
Conversation
As mentioned in ppy#36883. This has caught me off-guard a few times. Was a quick one to make this work like it does on stable. It doesn't fit as well as stable because we have a lot of elements at the top of the screen, but I think it's better than nothing, as it lets you know you're in a replay quick obviously. I don't think we can easily localise strings with formatting in them yet. Maybe using a `MarkdownContainer` or something?
bdach
requested changes
Mar 10, 2026
Comment on lines
+35
to
+36
| // TODO: This should be customised for `MultiplayerSpectatorPlayer` to be static and only show the player name. | ||
| // Or maybe we should completely redesign this to show the user avatar and other things if that happens. |
Collaborator
There was a problem hiding this comment.
For when is this TODO? Is it for this PR or for an indeterminate future?
Member
Author
There was a problem hiding this comment.
the latter. i'd want to get a designer involved. arguably that should be done before implementing this at all 🤷
Collaborator
|
The text probably shouldn't be on top of replay settings. 
|
Member
Author
|
That is a hard ask 😅 |
Collaborator
|
I mean if you're okay with that screenshot I can look the other way, but I had the feeling you wouldn't be... |
Member
Author
|
Yeah I'm not, will work on a solution. Layers are fun. |
bdach
approved these changes
Mar 11, 2026
|
pls add an option to disable it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in #36883.
This has caught me off-guard a few times.
Was a quick one to make this work like it does on stable. It doesn't fit as well as stable because we have a lot of elements at the top of the screen, but I think it's better than nothing, as it lets you know you're
in a replay quick obviously.
I don't think we can easily localise strings with formatting in them yet. Maybe using a
MarkdownContaineror something?